bugfix: reconcile max_seqs_per_batch with max_concurrent_requests. - #2016
Merged
Conversation
Kang-Meng
requested review from
Clement-Wang26,
DongheJin,
DragonFive,
JimHsiung,
RobbieLeung,
XuZhang99,
liujinguang0125,
liutongxuan,
walsonyang,
xiao-yu-chen,
yingxudeng,
yq33victor and
zhang-minchao
as code owners
July 23, 2026 09:45
weizhehuang0827
previously approved these changes
Jul 23, 2026
yingxudeng
reviewed
Jul 23, 2026
yingxudeng
reviewed
Jul 23, 2026
Collaborator
|
目前 cicd npu 失败,请补充本地 npu 通过所有单测的截图 |
Kang-Meng
force-pushed
the
bugfix_singleblock
branch
from
July 23, 2026 12:20
ff1506b to
ccf9e1f
Compare
Kang-Meng
force-pushed
the
bugfix_singleblock
branch
from
July 24, 2026 02:42
ccf9e1f to
62c356a
Compare
yingxudeng
approved these changes
Jul 24, 2026
weizhehuang0827
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startup in initialize_configs(): min when both > 0, the non-zero
one when one is 0, LOG(FATAL) when both are 0. Downstream users
(Master, Engine, BlockManagerPool, RateLimiter, ProfileManager)
now see the same effective cap on both fields.
ServiceConfig::max_concurrent_requests out of the box (keeps the
gflag DEFINE_* and the PROPERTY in-class default in sync per
custom-code-style §10).
when building BlockManagerPool::Options -- the SINGLE block pool
was falling back to a 2-slot capacity (1 padding + 1 usable),
effectively capping concurrent sequences at 1 on those paths.
0 by setting .max_seqs_per_batch(0) explicitly, so the intent to
drive the SINGLE pool from num_single_blocks alone stays local
and does not depend on Options' default value.