Skip to content

refactor: eliminate DisaggPDChunkedPrefillScheduler. #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weizhehuang0827 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: eliminate DisaggPDChunkedPrefillScheduler. #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/core/scheduler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ cc_test(
NAME
scheduler_test
SRCS
disagg_pd_chunked_prefill_scheduler_test.cpp
disagg_pd_scheduler_test.cpp
continuous_scheduler_test.cpp
fixed_steps_scheduler_test.cpp
Expand Down
5 changes: 2 additions & 3 deletions tests/core/scheduler/continuous_scheduler_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,15 +392,14 @@ TEST(ContinuousSchedulerFactoryTest,
opt.max_tokens_per_chunk_for_prefill());
}

TEST(SchedulerFactoryTest, DisaggPDChunkedPrefillKind) {
TEST(SchedulerFactoryTest, DisaggPDChunkedPrefillUsesDisaggPD) {
ContinuousScheduler::Options opt =
create_scheduler_options(10000, 256, 2, 1024, 1);
opt.enable_disagg_pd() = true;
opt.enable_pd_ooc() = false;
opt.enable_chunked_prefill() = true;

EXPECT_EQ(select_scheduler_kind(opt),
SchedulerKind::DISAGG_PD_CHUNKED_PREFILL);
EXPECT_EQ(select_scheduler_kind(opt), SchedulerKind::DISAGG_PD);
}

TEST(SchedulerFactoryTest, DisaggPDOOCKeepsPDOOCKind) {
Expand Down
Loading
Loading