Skip to content

bugfix: map global ranks to local devices.#2019

Merged
phantomlei3 merged 1 commit into
xLLM-AI:mainfrom
phantomlei3:bugfix/multi-device
Jul 24, 2026
Merged

bugfix: map global ranks to local devices.#2019
phantomlei3 merged 1 commit into
xLLM-AI:mainfrom
phantomlei3:bugfix/multi-device

Conversation

@phantomlei3

@phantomlei3 phantomlei3 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

  • validate global rank and visible device count before device selection
  • add multi-node rank mapping regression tests and document logical device behavior

Related Issues

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor
  • Documentation
  • Test
  • Build or CI

Pull Request Checklist

Thank you for contributing to xLLM. Before requesting review, please make sure the following items are complete.

PR Title and Commit Messages

  • The PR title and each commit message follow the xLLM commit format: <type>: <subject>.

Allowed types: feat, bugfix, docs, test, refactor, chore, style, revert, perf, model, build, release.
The subject should use clear English, start with a verb, include at least 4 words, and end with ..

Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit or an equivalent command.
  • I have installed the hooks with pre-commit install.
  • I have run pre-commit run --all-files and fixed any reported issues.

If you are unsure how to set up pre-commit, see the pre-commit documentation.

Self Review

  • I have self-reviewed the code according to .agents/skills/code-review/references/custom-code-style.md, especially code written or assisted by AI.
  • I have rebased this PR onto the latest main branch.

Build and Test Coverage

  • Tests have been added or updated as needed.
  • CUDA: python setup.py build test has passed on a CUDA machine.
  • NPU: python setup.py build test has passed on an NPU machine.
  • MLU: python setup.py build test has passed on an MLU machine.

Reviewer Notes

- validate global rank and visible device count before device selection
- add multi-node rank mapping regression tests and document logical device behavior
@phantomlei3
phantomlei3 merged commit 5f2bc48 into xLLM-AI:main Jul 24, 2026
17 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants