Fixed bug with inventory glitching. (Probably #2)

xZoidy · Feb 10, 2017 · 1fdb499 · 1fdb499
1 parent 1125289
commit 1fdb499
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/ChestShop/EventListener.php b/src/ChestShop/EventListener.php
@@ -34,6 +34,7 @@
 
 class EventListener implements Listener{
 
+	const DEFAULT_PRICE = 15000;
 	protected $plugin;
 
 	public function __construct(Main $plugin){
@@ -61,18 +62,19 @@ public function onTransaction(InventoryTransactionEvent $event){
 		$action = null;
 		foreach($transactions as $transaction){
 			if(($inv = $transaction->getInventory()) instanceof CustomChestInventory){
-				foreach($inv->getViewers() as $assumed)
-					if($assumed instanceof Player) {
+				foreach($inv->getViewers() as $assumed){
+					if($assumed instanceof Player){
 						$player = $assumed;
 						$chestinv = $inv;
+						$action = $transaction;
 						break;
 					}
+				}
 			}
-			$action = $transaction;
 		}
+
 		if($chestinv === null) return;
 		$event->setCancelled();
-
 		$item = $action->getTargetItem();
 
 		if(isset($item->getNamedTag()->turner)){
@@ -84,7 +86,7 @@ public function onTransaction(InventoryTransactionEvent $event){
 
 		$data = $item->getNamedTag()->ChestShop->getValue() ?? null;
 		if($data === null) return;
-		$price = $data[0] ?? 15000;
+		$price = $data[0] ?? self::DEFAULT_PRICE;
 		if(!isset($this->plugin->clicks[$player->getId()][$data[1]])){
 			$this->plugin->clicks[$player->getId()][$data[1]] = 1;
 			return;