Include quoted_tweet_id in seen/served related-post ids - #151
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Include quoted_tweet_id in seen/served related-post ids#151Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Quote cards reuse the quoted original. PreviouslySeen and PreviouslyServed only walked tweet/retweet/reply ids, so a quote of an already-seen post was treated as new inventory. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related_post_ids_iterwalked tweet/retweet/reply ids only, so seen/served filters missed quote-as-same-card.QuoteHydrator fills
quoted_tweet_idbefore PreviouslySeen, PreviouslySeenBackup, and PreviouslyServed.Chain
quoted_tweet_idnext to retweet and reply. Leftover of #138, not a Thunder delete.Tests: iterator includes the quote; backup filter drops a quote of an impressed original. Standalone 5/5.
home-mixer has no Cargo.toml in this snapshot.