Fail closed when Flock mute/block graph slots are missing - #162
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Fail closed when Flock mute/block graph slots are missing#162Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
A truncated Flock multi-query used to decode missing mute/block slots as empty sets. Require all four relationship slots; otherwise treat the read as failed so muted and blocked authors are not assembled as safe. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
decode_relationship_edgesmapped a truncated Flock multi-query onto empty mute/block/mute-retweet sets. RPC success with 1–3 result slots therefore assembledviewer_mutes_author = false/viewer_blocks_author = false.A total Flock
Erralready returns an empty map (SocialgraphHydratormarks Failed). Four empty slots is a confirmed unlabeled read. Those paths are unchanged.This is not #137 (total Failed assembled via
get_or_default). #137 leftover: "Partial Flock result slots still default missing mute/block graphs to empty."Five-line proof
decode_relationship_edges(next_edge_setusedunwrap_or_defaultfor missing slots)ViewerMutesAuthorRule/ViewerBlocksAuthorRule/MutedRetweetsRuleChange
Require exactly four result slots (follows, blocks, mutes, mute-retweets). Otherwise return no relationships, same sink as RPC
Err. Four empty slots remain a successful all-false read.Tests
None)Standalone decision-table harness (same match arms): 8 assertions passed.
cargo testcannot run. Public dump has no visibility-filtering manifest.Fork PR: none