Drop retweets whose original author handle matches a muted keyword - #164
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
ViewerMutedKeywordFilter only tokenized tweet_text. Gizmoduck already filled retweeted_screen_name on For You, and Night Owl already sets retweeted_user_id on Latest Following, but neither mute-keyword filter matched the original author handle. A followee retweeting @spamAccount ("hello") still served when the viewer muted the keyword spamaccount. Mention-in-text already drops; mute-by-id is already AuthorSocialgraphFilter (#9). This is the leftover author-of-retweeted edge, twin of quoted-author handle (xai-org#140). Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retweeted_user_id; Gizmoduck already writesretweeted_screen_nameon For YouFollowingViewerMutedKeywordFilter/ViewerMutedKeywordFiltertest_mention_keyworddrops @handle in tweet_text; mute-by-id is Fix muted authors resurfacing through retweets #9Fork PR: none