Skip to content

media-model-proxy: fail closed when every NSFW replica drops scores #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pitchfork-and-Torch wants to merge 1 commit into from
+43 −8
Closed

media-model-proxy: fail closed when every NSFW replica drops scores #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...y/src/main/scala/com/twitter/media_understanding/model_proxy/services/ModelsService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,22 @@ class ModelsService(

Future
.collectToTry(result)
.map { responses: Seq[Try[PredictionResponse]] =>
responses
.flatMap { responses: Seq[Try[PredictionResponse]] =>
val successes = responses
.filter { response => filterException(response, model) }
.map { predictionResponseTry => predictionResponseTry.get().prediction }

// Attempted replicas that all fail must not become a successful empty
// score list: callers persist that as unlabeled / SFW.
if (result.nonEmpty && successes.isEmpty) {
val cause = responses
.collectFirst { case Throw(ex) => ex }
.getOrElse(new IllegalStateException(s"${model.name} produced no scores"))
stats.scope(model.name).counter("fail_closed").incr()
Future.exception(cause)
} else {
Future.value(successes)
}
}
}
}
Expand Down
35 changes: 29 additions & 6 deletions ...c/test/scala/com/twitter/media_understanding/model_proxy/services/ModelsServiceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.twitter.cortex_media_annotator.thriftscala.MediaModel
import com.twitter.finagle.NoBrokersAvailableException
import com.twitter.finagle.stats.NullStatsReceiver
import com.twitter.media_understanding.model_proxy.clients.ModelClient
import com.twitter.media_understanding.model_proxy.exception.GreyScaleImageException
import com.twitter.media_understanding.model_proxy.model_descriptors.ModelDescriptor
import com.twitter.media_understanding.model_proxy.model_descriptors.ModelDescriptorRegistry
import com.twitter.mediaservices.commons.thriftscala.MediaCategory
Expand Down Expand Up @@ -88,7 +89,7 @@ class ModelsServiceSpec extends FunSuite with MockitoSugar with BeforeAndAfterEa
}

test(
"getPrediction returns empty list of response if all models in cluster throw PredictionException"
"getPrediction fails closed if all models in cluster throw PredictionException"
) {
when(client_1.isAvailable)
.thenReturn(true)
Expand All @@ -100,12 +101,13 @@ class ModelsServiceSpec extends FunSuite with MockitoSugar with BeforeAndAfterEa
when(client_2.predictFromModel(mockAny[PredictionRequest]))
.thenReturn(Future.exception(new PredictionServiceException("")))

val result = Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
assert(result.isEmpty)
intercept[PredictionServiceException] {
Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
}
}

test(
"getPrediction returns empty list of response if all models in cluster throw non fatal exceptions"
"getPrediction fails closed if all models in cluster throw non fatal exceptions"
) {
when(client_1.isAvailable)
.thenReturn(true)
Expand All @@ -117,8 +119,27 @@ class ModelsServiceSpec extends FunSuite with MockitoSugar with BeforeAndAfterEa
when(client_2.predictFromModel(mockAny[PredictionRequest]))
.thenReturn(Future.exception(new IllegalArgumentException()))

val result = Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
assert(result.isEmpty)
intercept[IllegalArgumentException] {
Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
}
}

test(
"getPrediction fails closed with GreyScaleImageException when every replica hits a greyscale decode error"
) {
val grey = new PredictionServiceException(deepBirdService.greyScaleErrorString)
when(client_1.isAvailable)
.thenReturn(true)
when(client_2.isAvailable)
.thenReturn(true)
when(client_1.predictFromModel(mockAny[PredictionRequest]))
.thenReturn(Future.exception(grey))
when(client_2.predictFromModel(mockAny[PredictionRequest]))
.thenReturn(Future.exception(grey))

intercept[GreyScaleImageException] {
Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
}
}

test(
Expand Down Expand Up @@ -155,6 +176,8 @@ class ModelsServiceSpec extends FunSuite with MockitoSugar with BeforeAndAfterEa
when(client_2.isAvailable)
.thenReturn(false)

// Kill-switched / filtered-out replicas were never attempted, so empty is
// not a swallowed error.
val result2 = Await.result(deepBirdService.getPrediction(Some(mediaCategory), model, media))
assert(result2.isEmpty)
}
Expand Down