Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to never resolve parent path when vhd-util query is called #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wescoeur
Copy link
Contributor

@Wescoeur Wescoeur commented May 9, 2023

Add the ability to vhd-util to find the parent of a VHD without locally resolving or calling stat on the locator path.
A cmdline option -u (unresolved) is now available to query the parent path without resolution.

Use cases:

  • When a special SR driver is used where the parent is not always accessible on the master (DRBD case).
  • A copy of a VHD on an external device without parent
  • ...

Example:

vhd-util query -u -n /dev/drbd/by-res/xcp-volume-1d86819f-c844-4250-8f3a-df5de9227baa/0 -p
../xcp-volume-56c6ef19-3d87-4838-b5e6-9c534bc1a0cb/0

Copy link

@benjamreis benjamreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@MarkSymsCtx what do you think of this change?
Would that be of interest to you?

@Wescoeur
Copy link
Contributor Author

@TimSmithCtx @MarkSymsCtx I know you are busy but can you take a look? Thanks! 🙂

Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like quite a specialised case which may not get a lot of use but you do obviously have a use for it so it looks good to me.

@stormi
Copy link

stormi commented Jan 22, 2024

Is something missing to reach the point of merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants