CA-379315 Use XE_SR_ERRORCODES in the LVM journaller #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than allow JournalerExceptions to propagate up and eventually turn into "unhandled" error 1200s, turn all instances into the appropriate type of LVM error code and reture the JournalerException class, at least from the LVM journaller Signed-off-by: Tim Smith <[email protected]>
rosslagerwall
previously approved these changes
Aug 15, 2023
Helps to test that the errors behave as they should Signed-off-by: Tim Smith <[email protected]>
TimSmithCtx
force-pushed
the
private/timsmi/CA-379315
branch
from
72bbd73
to
bd42863
Compare
MarkSymsCtx
approved these changes
Sep 4, 2023
KevinLCtx
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than allow JournalerExceptions to propagate up and eventually turn into "unhandled" error 1200s, turn all instances into the appropriate type of LVM error code and reture the JournalerException class, at least from the LVM journaller