-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs build #480
Fix docs build #480
Conversation
I'm working through the numpydocs warnings now as well. |
Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
===========================================
- Coverage 86.11% 63.60% -22.51%
===========================================
Files 22 22
Lines 4220 4212 -8
Branches 223 223
===========================================
- Hits 3634 2679 -955
- Misses 526 1449 +923
- Partials 60 84 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok all the warnings are gone locally. I'll watch the PR readthedocs build to confirm that that's the case there as well. The big changes are in fc2ea8c where I exclude some methods/files and ignore some classes of warnings. |
A lot fewer! I don';t mind merging with these.
|
Yeah this is numpydoc 1.5.0 (RTD) vs 1.6.0 (what I have locally). The more revent version is better at handling the inline ignore comments. So yeah I agree. I am happy merging as is |
Docs build is broken on main. This seems to fix it locally. Ref: sphinx-doc/sphinx#11094 (comment)