[genesis-scripts]Minor logic and piping improvements #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samveen So are the changes to the 14 files in this PR due to the suggestions from running ShellCheck ? |
|
@gurevichmark No it isn't just ShellCheck improvements, there are also some minor improvements that I had made prior to running ShellCheck. However all the changes here are a subset of pull request #4923 which I'd submitted previously. However, as the previous pull request also had some changes that didn't work properly on Power machines, therefore I've had to split that into 2, one this, and another one to be created (after this is merged), with the breaking changes, so that those can be reviewed and fixed more easily. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to partially fix issue #4610
The code here was previously part of Pull request #4923 . For easier checks, this contains the easily-checked portions of the above PR. The code with logic flow changes from the previous PR will be added as another PR once this is merged.