Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xCAT-server]Change DNS/DHCP control key algorithm MD5 -> SHA512 #6797

Closed
wants to merge 2 commits into from

Conversation

samveen
Copy link
Member

@samveen samveen commented Aug 8, 2020

The PR is to fix issue #6757

The modification include

  • Change all omshell access to use key-algorithm hmac-sha512 instead of the default hmac-md5
  • Change named/dhcpd config generating code to use algorithm hmac-sha512 instead of hmac-md5

The UT result

I don't have a test environment for this, so nothing tested.

@cxhong
Copy link
Contributor

cxhong commented Aug 10, 2020

@samveen , thanks.
I modified /opt/xcat/share/xcat/tools/dhcpop and ran a test to remove mac from lease file

]# /opt/xcat/share/xcat/tools/dhcpop -r -n mid08tor03cn01
<STDIN> line 1: unknown token: key-algorithm
key-algorithm
^
# diff dhcpop dhcpop.orig
42d41
<     print $omshell "key-algorithm HMAC-SHA512\n";

I tried on both rhel8 and rhel7 system, both failed

@cxhong
Copy link
Contributor

cxhong commented Aug 24, 2020

@samveen , did u have chance to look into this PR? even without enable FIPS, this modification didn't work from my testing.

@samveen
Copy link
Member Author

samveen commented Aug 29, 2020

@cxhong would you give me the output or rpm -qf $(which omshell) in the environment where the testing failed?

@cxhong
Copy link
Contributor

cxhong commented Aug 31, 2020

on the redhat7.7:

# which omshell
/usr/bin/omshell
# rpm -qf /usr/bin/omshell
dhcp-4.2.5-77.el7.ppc64le

@kjhee43
Copy link

kjhee43 commented Oct 15, 2020

@cxhong what's the latest status of this patch? Any update to get it working?

@samveen
Copy link
Member Author

samveen commented Oct 18, 2020

@kjhee43 @cxhong I unfortunately don't have access to a test environment anymore, so I am unable to test this to make a fix.

Is there a test environment that I can access to test this on?

@kjhee43
Copy link

kjhee43 commented Oct 20, 2020

@samveen I dont have one you can access. Can you provide me the patch to test?

@cxhong
Copy link
Contributor

cxhong commented Oct 23, 2020

@samveen , we don't have system for public access.
@kjhee43 , the patch is in this PR. https://github.com/xcat2/xcat-core/pull/6797.patch you can manually modified the changes on your xCAT management node.

@besawn besawn modified the milestones: 2.16.1, 2.16.2 Oct 27, 2020
@peterwywong peterwywong removed this from the 2.16.2 milestone May 17, 2021
@ddo262
Copy link

ddo262 commented Jun 3, 2021

@cxhong redhat release a fix for rhel 8 where you can change the omshell algroithm.
https://bugzilla.redhat.com/show_bug.cgi?id=1883999

@samveen
Copy link
Member Author

samveen commented Jun 1, 2023

This is stale, (and badly implemented), and #7389 fixes the issue in a more structured way. Closing.

@samveen samveen closed this Jun 1, 2023
@samveen samveen deleted the fix_6757 branch June 1, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants