Fix MTM detection for incomplete FRU pages

[kcgthb]

The PR is to fix issue #7397

When FRU pages include empty fields (more precisely blank fields that are just spaces), the FRU parsing in dodiscovery returns blank values.

This PR makes sure that blank fields containing only spaces are ignored, so the correct field can be returned.

For instance, with the following FRU page:

# ipmitool fru print 0
 Chassis Type          : Other
 Chassis Part Number   : CSE-228GTS-R2K21P
 Chassis Serial        : [redacted]
 Board Mfg Date        : Sun Apr 23 04:33:00 2023 PDT
 Board Mfg             : Supermicro
 Board Product         : H12DSG-Q-CPU6
 Board Serial          : [redacted]
 Board Part Number     : H12DSG-Q-CPU6
 Product Manufacturer  : Supermicro
 Product Name          :
 Product Part Number   : AS -2124GQ-NART
 Product Version       :
 Product Serial        : [redacted]
 Product Asset Tag     :

the original dodiscovery script returns

# ipmitool fru print 0 | awk -F': ' '/Product Manufacturer/ {m=$2} /Product Name|Product Part Number/ {if (n==""||n=="NONE") {n=$2}} END {print m":"n}'
Supermicro:

And with the fix:

# ipmitool fru print 0 | awk -F': ' '/Product Manufacturer/ {m=$2} /Product Name|Product Part Number/ {if (n==""||n~/ +/||n=="NONE") {n=$2}} END {print m":"n}'
Supermicro:AS -2124GQ-NART

[samveen]

@kcgthb Killian, how about changing ~/ +/ to ~/\s+/ to handle all whitespace?

[kcgthb]

That's a good suggestion, thank you!

I've never seen a non-space whitespace character in a FRU field yet, but well, until recently and the Supermicro "AS- " line of servers, I had never seen a space either, so 🤷