Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configib: fix/clean up el9 support #7459

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

alexrichert
Copy link
Contributor

@alexrichert alexrichert commented Jul 25, 2024

The PR is to fix issue #7453

The modifications include

  • Remove EL9-specific logic from non-redhat OSes
  • Add EL9 connections with nmcli before modifying them for nicextraparams
  • Don't populate $cfgfile when using EL9

The UT result

##The UT output##

@alexrichert
Copy link
Contributor Author

@Obihoernchen I noticed a number of issues with my previous attempt, 🤞 this should work better...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexrichert
Copy link
Contributor Author

We've tested with EL8 and EL9. It doesn't break EL8, and in EL9, it creates a NM connection and does not try to remove or write an ifcfg file.

@Obihoernchen Obihoernchen added this to the 2.17 milestone Aug 27, 2024
@Obihoernchen Obihoernchen merged commit 39664c5 into xcat2:master Aug 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants