Add waitForProcessComplete #459
zklgameAnnotations
5 errors and 1 warning
|
golangci-lint:
service/async/service_impl.go#L248
[golangci] reported by reviewdog 🐶
copylocks: createWaitingChannelsAndStart passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
Raw Output:
service/async/service_impl.go:248:9: copylocks: createWaitingChannelsAndStart passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
func (a asyncService) createWaitingChannelsAndStart(shardId int32) {
^
|
|
golangci-lint:
service/async/service_impl.go#L257
[golangci] reported by reviewdog 🐶
copylocks: stopWaitingChannelsAndRemove passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
Raw Output:
service/async/service_impl.go:257:9: copylocks: stopWaitingChannelsAndRemove passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
func (a asyncService) stopWaitingChannelsAndRemove(shardId int32) {
^
|
|
golangci-lint:
service/async/service_impl.go#L326
[golangci] reported by reviewdog 🐶
copylocks: AskRemoteToWaitForProcessCompletionInCluster passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
Raw Output:
service/async/service_impl.go:326:9: copylocks: AskRemoteToWaitForProcessCompletionInCluster passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
func (a asyncService) AskRemoteToWaitForProcessCompletionInCluster(
^
|
|
golangci-lint:
service/async/service_impl.go#L357
[golangci] reported by reviewdog 🐶
copylocks: WaitForProcessCompletion passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
Raw Output:
service/async/service_impl.go:357:9: copylocks: WaitForProcessCompletion passes lock by value: github.com/xcherryio/xcherry/service/async.asyncService contains sync.RWMutex (govet)
func (a asyncService) WaitForProcessCompletion(ctx context.Context, req xcapi.WaitForProcessCompletionRequest,
^
|
|
golangci-lint
reviewdog exited with status code: 1
|
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|