Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visibility store #116

Merged
merged 7 commits into from
Feb 24, 2024
Merged

add visibility store #116

merged 7 commits into from
Feb 24, 2024

Conversation

duoertai
Copy link
Collaborator

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/sdk-go PRs if it's on top of any API changes]

  • API change link: ...
  • Golang SDK change link: ...
  • Server Component 1: ...
  • Server Component 2: ...

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/sdk-go PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/sdk-go

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (19097d8) 63.66% compared to head (c0d9bdb) 63.81%.

❗ Current head c0d9bdb differs from pull request most recent head 678f4d9. Consider uploading reports for the commit 678f4d9 to get more accurate results

Files Patch % Lines
cmd/server/bootstrap/xcherry.go 42.85% 7 Missing and 1 partial ⚠️
config/config.go 25.00% 2 Missing and 1 partial ⚠️
engine/immediate_task_concurrent_processor.go 72.72% 3 Missing ⚠️
extensions/sql_db_schema_tool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   63.66%   63.81%   +0.15%     
==========================================
  Files          87       87              
  Lines        6597     6608      +11     
==========================================
+ Hits         4200     4217      +17     
+ Misses       2126     2120       -6     
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duoertai duoertai marked this pull request as ready for review February 20, 2024 14:43
@duoertai duoertai merged commit dc9a295 into main Feb 24, 2024
3 checks passed
@duoertai duoertai deleted the add-visibility-store branch February 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants