Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process visibility task #117

Merged
merged 4 commits into from
Mar 7, 2024
Merged

process visibility task #117

merged 4 commits into from
Mar 7, 2024

Conversation

duoertai
Copy link
Collaborator

@duoertai duoertai commented Mar 4, 2024

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/sdk-go PRs if it's on top of any API changes]

  • API change link: ...
  • Golang SDK change link: ...
  • Server Component 1: ...
  • Server Component 2: ...

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/sdk-go PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/sdk-go

@duoertai duoertai requested a review from longquanzheng March 4, 2024 15:09
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.94%. Comparing base (19097d8) to head (9e177af).
Report is 1 commits behind head on main.

Files Patch % Lines
persistence/visibility/visibility_store.go 73.91% 4 Missing and 2 partials ⚠️
engine/immediate_task_concurrent_processor.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   63.66%   63.94%   +0.27%     
==========================================
  Files          87       87              
  Lines        6597     6653      +56     
==========================================
+ Hits         4200     4254      +54     
+ Misses       2126     2125       -1     
- Partials      271      274       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duoertai duoertai marked this pull request as ready for review March 5, 2024 10:22
@duoertai
Copy link
Collaborator Author

duoertai commented Mar 5, 2024

tested in local env

@longquanzheng
next thing to do is to delete immediate task after visibility task is finished, but since visibility table could be in different database/cluster, I suppose we don't need to use transaction to process visibility and delete immediate task

@duoertai duoertai merged commit 9633341 into main Mar 7, 2024
5 checks passed
@duoertai duoertai deleted the process-visibility-task branch March 7, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants