Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visibility queries #120

Merged
merged 5 commits into from
Mar 14, 2024
Merged

add visibility queries #120

merged 5 commits into from
Mar 14, 2024

Conversation

duoertai
Copy link
Collaborator

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/sdk-go PRs if it's on top of any API changes]

  • API change link: ...
  • Golang SDK change link: ...
  • Server Component 1: ...
  • Server Component 2: ...

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/sdk-go PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/sdk-go

@duoertai duoertai requested a review from longquanzheng March 11, 2024 15:54
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 4.52962% with 274 lines in your changes are missing coverage. Please review.

Project coverage is 61.38%. Comparing base (f93c258) to head (88c24e5).

❗ Current head 88c24e5 differs from pull request most recent head 1f6d894. Consider uploading reports for the commit 1f6d894 to get more accurate results

Files Patch % Lines
persistence/visibility/visibility_store.go 0.00% 118 Missing ⚠️
extensions/postgres/non_transactional.go 0.00% 85 Missing ⚠️
service/api/service_impl.go 26.66% 22 Missing ⚠️
persistence/data_models/pagination_token_json.go 0.00% 18 Missing ⚠️
service/api/gin_handler.go 10.52% 17 Missing ⚠️
persistence/data_models/data_models_enums.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   63.92%   61.38%   -2.54%     
==========================================
  Files          87       88       +1     
  Lines        6661     6933     +272     
==========================================
- Hits         4258     4256       -2     
- Misses       2128     2401     +273     
- Partials      275      276       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duoertai
Copy link
Collaborator Author

tested all 5 queries in local env

@duoertai duoertai merged commit c5da3b2 into main Mar 14, 2024
3 checks passed
@duoertai duoertai deleted the add-visibility-queries branch March 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants