Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server image #127

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix server image #127

merged 1 commit into from
Jun 12, 2024

Conversation

zklgame
Copy link
Collaborator

@zklgame zklgame commented Jun 12, 2024

Why make this pull request?

[Explain why you are making this pull request and what problem it solves.]

What has changed

[Summarize what components of the repo is updated]

[Link to xdb-apis/sdk-go PRs if it's on top of any API changes]

  • API change link: ...
  • Golang SDK change link: ...
  • Server Component 1: ...
  • Server Component 2: ...

How to test this pull request?

[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]

[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]

[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]

Checklist before merge

[ ] If applicable, merge the xdb-apis/sdk-go PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update go.mod to use the commitID of the main branches for xdb-apis/sdk-go

@zklgame zklgame requested a review from longquanzheng June 12, 2024 06:08
@zklgame zklgame merged commit 5ea0f31 into main Jun 12, 2024
4 checks passed
@zklgame zklgame deleted the fix_image branch June 12, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants