Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(XCP-ng) Fix broken links in the XCP-ng documentation #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas-dkmt
Copy link
Collaborator

@thomas-dkmt thomas-dkmt commented Feb 25, 2025

In the XCP-ng documentation, some links pointed to locations that were obsolete or just don't exist anymore (404 error, and some 503 errors).

  • Wherever a more appropriate target location could be found, the links are now fixed.
  • One dead link has been replaced by the actual, relevant content.
  • Links where no substitute could be found have been removed.

@julien-f julien-f requested review from stormi and removed request for julien-f February 25, 2025 14:48
@Fohdeesha
Copy link
Member

So for the "Follow this (ignore steps 6 and 7, do not try to install the tools yet) https://support.citrix.com/article/CTX215427" line, I found a wayback copy of it, and all it's saying to do is delete two registry folders:

HKLM\SYSTEM\CurrentControlSet\Enum\XENBUS
HKLM\SYSTEM\CurrentControlSet\Enum\XENVIF

given half of the other steps in this list in our docu is also deleting registry keys, we can just put the two keys directly in a new line there, and get rid of the instruction line with this dead link

@thomas-dkmt thomas-dkmt changed the title WIP: Fix broken links in the XCP-ng documentation doc(XCP-ng) Fix broken links in the XCP-ng documentation Feb 27, 2025
@dinhngtu
Copy link
Member

Hi, I've created a PR with instructions for using XenClean (#326). That should replace the old instructions for removing old Citrix drivers.

@thomas-dkmt thomas-dkmt force-pushed the doc-fix-broken-link-installsources branch from 3ca2b0d to 04700bc Compare March 21, 2025 08:43
@stormi
Copy link
Member

stormi commented Mar 24, 2025

Is the merge from master into this branch on purpose? If it is, we usually prefer a rebase of the PR branch over a merge commit.

Some links pointed to websites that no longer exist, with no known replacement.
These links are now removed.
The other links have been fixed to point to the correct location, where possible.

Signed-off-by: Thomas Moraine <[email protected]>
@thomas-dkmt thomas-dkmt force-pushed the doc-fix-broken-link-installsources branch from 035dc69 to 9bb22c1 Compare April 10, 2025 12:42
@stormi
Copy link
Member

stormi commented Apr 11, 2025

There's a conflict with the master branch. You'll need to rebase on master (and solve the conflict in the process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants