Make parameter extraction more robust and ignore magic #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter detection now uses a Python exporter to convert notebook code in the parameter cell and the setup cells that precede it, rather than (as previously) just extracting the code directly from the cell. Also, a code snippet is prepended to the exported user code which defines get_ipython() as a MagicMock, effectively turning all magic commands (which wouldn't work outside IPython) into no-ops. Addresses Issue 14.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 74.09% 74.21% +0.11%
==========================================
Files 6 6
Lines 471 477 +6
Branches 55 55
==========================================
+ Hits 349 354 +5
- Misses 115 116 +1
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was already done during parameter extraction, but this commit also adds the mock to the final script output, making the script runnable (in principle) outside an IPython environment. This commit also fixes a minor unittest import problem.
pont-us
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter detection now uses a Python exporter to convert notebook code in the parameter cell and the setup cells that precede it, rather than (as previously) just extracting the code directly from the cell.
Also, a code snippet is prepended to the exported user code (both during parameter extraction and in the final exported script) which defines get_ipython() as a MagicMock, effectively turning all magic commands (which wouldn't work outside IPython) into no-ops.
Closes #14 .