Add port option, and remove run functionality from build subcommand #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
These options complicate the UI and are redundant; effectively they duplicate the functionality of the "image run" subcommand. See Issue #3.
The "--server" option now takes an optional "port" argument.
micromamba xcube install is currently broken: all current xcube packages are (directly or transitively) Python 3.13 incompatible, but older ones aren't marked as such, so without a pin micromamba installs Python 3.13 and incompatible xcube 1.7.1.
Click has trouble parsing optional parameters to options reliably, so --server is now a flag again and --port is a new option that always takes exactly one parameter.
The version incompatibility has been solved by a Python 3.13 compatible chartlets release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3