Skip to content

Conversation

@tinaok
Copy link

@tinaok tinaok commented Oct 8, 2024

No description provided.

@tinaok
Copy link
Author

tinaok commented Nov 26, 2024

@annefou I want to merge this commit, is this error from pre-commit, something we can ignore?

@annefou
Copy link

annefou commented Nov 26, 2024

No, I can fix it. Can you add me as collaborator to https://github.com/tinaok/xdggs_examples ?

@tinaok
Copy link
Author

tinaok commented Nov 26, 2024

I'm a member, so I can't I think @keewis can.

@annefou
Copy link

annefou commented Nov 26, 2024 via email

@tinaok
Copy link
Author

tinaok commented Nov 26, 2024

Thank you anne!

@annefou
Copy link

annefou commented Nov 26, 2024

Do you want to merge it?

Copy link
Member

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the install instructions in the notebook are out-of-date, this should be just pip install xdggs now.

annefou and others added 2 commits November 26, 2024 14:04
@annefou
Copy link

annefou commented Nov 26, 2024

the install instructions in the notebook are out-of-date, this should be just pip install xdggs now.

Should we also pin the version?

@keewis
Copy link
Member

keewis commented Nov 26, 2024

not sure. I don't think the interface will change as drastically as between 0.0.1 and 0.1.0, but if you want to be absolutely sure you can pin it to 0.1

and make directly install from pypi
@annefou
Copy link

annefou commented Nov 26, 2024

I would suggest we add xdggs in the condo environment and then remove it from the jupyter notebook. What do you think? @tinaok @keewis

@tinaok
Copy link
Author

tinaok commented Nov 26, 2024

I think it only works with pip (and not with condo) for xdggs today

@annefou
Copy link

annefou commented Nov 26, 2024

Yes. But we could add it in the pip section of .binder/environment.yml?

@tinaok
Copy link
Author

tinaok commented Nov 26, 2024

yes

and explain the two different ways to get xdggs e.g. with pip only or using the environment.yml file from .binder folder
@tinaok
Copy link
Author

tinaok commented Dec 8, 2024

@keewis can we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants