libxdp: Modify semantic of fill and comp in xsk_socket_opts, with tests edited#462
Merged
tohojo merged 3 commits intoxdp-project:masterfrom Jan 8, 2025
Merged
libxdp: Modify semantic of fill and comp in xsk_socket_opts, with tests edited#462tohojo merged 3 commits intoxdp-project:masterfrom
tohojo merged 3 commits intoxdp-project:masterfrom
Conversation
tohojo
reviewed
Dec 14, 2024
Use umem's fill_save and fill_comp if fill and comp in opts are both unset when calling xsk_socket__create_opts(), otherwise use what they are set in opts. This is to keep the same semantic as xsk_socket__create() and xsk_socket__create_shared(). Signed-off-by: Muyang Tian <tianmuyang@huawei.com>
Signed-off-by: Muyang Tian <tianmuyang@huawei.com>
tacslon
force-pushed
the
feat/xsk-sock
branch
from
e96a134 to
f0b6a86
Compare
tacslon
changed the title
tohojo
reviewed
Dec 16, 2024
Signed-off-by: Muyang Tian <tianmuyang@huawei.com>
tohojo
approved these changes
Dec 16, 2024
Member
tohojo
left a comment
tohojo
left a comment
There was a problem hiding this comment.
LGTM - @magnus-karlsson PTAL :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
umem'sfill_saveandfill_compiffillandcompin opts are both unset when callingxsk_socket__create_opts(), otherwise use what they are set in opts. Add validation for only one offillandcompare set.This is to keep the same semantic as
xsk_socket__create()andxsk_socket__create_shared().Also, use opts-style API to create XDP socket in libxdp tests.