Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated API call for blocker_violations #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated API call for blocker_violations #4

wants to merge 1 commit into from

Conversation

brhahlen
Copy link

@brhahlen brhahlen commented Dec 8, 2017

Fixes #3

@brhahlen
Copy link
Author

brhahlen commented Dec 8, 2017

Full transparency:
I have not been able to test this (yet), due to the fact that I do not have a SonarQube available at the moment.
However, according to the docs (https://docs.sonarqube.org/display/SONAR/Metric+Definitions#MetricDefinitions-Issues) this has to work.

jdewinne
jdewinne reviewed Dec 8, 2017
View reviewed changes
Copy link
Contributor

@jdewinne jdewinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test it with https://sonarcloud.io/projects?sort=-analysis_date

src/main/resources/sonar/VerifyNoBlockingViolations.py
# major_violations 0
# sqale_index < 3000
#
if blocking_violations == 0 and major_violations < 351 and sqale_index < 9000:
if blocker_violations == 0 and major_violations < 351 and sqale_index < 9000:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to make 351 and 9000 configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdewinne jdewinne jdewinne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brhahlen @jdewinne