Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Base] Added Listing directories and filtering filenames by regex #2140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gliniak
Copy link
Member

@Gliniak Gliniak commented Mar 12, 2023

No description provided.

src/xenia/base/filesystem.h Outdated Show resolved Hide resolved
@Gliniak Gliniak force-pushed the ListDirectories&FilterFileNameByRegex branch from c7f82ed to c4b6651 Compare March 22, 2023 12:47
@Gliniak Gliniak force-pushed the ListDirectories&FilterFileNameByRegex branch from c4b6651 to 2ff4ff6 Compare August 3, 2023 19:46
@@ -123,6 +124,9 @@ struct FileInfo {
};
bool GetInfo(const std::filesystem::path& path, FileInfo* out_info);
std::vector<FileInfo> ListFiles(const std::filesystem::path& path);
std::vector<FileInfo> ListDirectories(const std::filesystem::path& path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the files where these functions are called accidentally slip under the radar of git add?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these will be used in the future and in different PRs.
It will simplify loading patches and simplify loading profile directories in the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may end up being removed as dead code at some point between the merging of this pull request and when the patches/profile changes arrive, or it may just deteriorate as nothing tests this code in practice, I think it'd be safer to submit these functions alongside the first use of them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that, but it's quite annoying if that change would appear in many PRs.
Maybe instead it would be better to add note about future usage?

Especially when we consider how long resolving all quirks in bigger PRs might take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants