Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

CP-45071: Convert XenCenter build scripts to PowerShell. #3219

Merged
merged 6 commits into from
Sep 6, 2023
Merged

CP-45071: Convert XenCenter build scripts to PowerShell. #3219

merged 6 commits into from
Sep 6, 2023

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Sep 4, 2023

Commits best reviewed separately.

@kc284 kc284 self-assigned this Sep 4, 2023
danilo-delbusso
danilo-delbusso suggested changes Sep 5, 2023
View reviewed changes
@danilo-delbusso danilo-delbusso added the needs updating A reviewer has requested changes label Sep 5, 2023
@kc284
Pass the timestamp server and the certificate thumbprint as parameter…
d44c8a0 
…s to the build and sign scripts.

Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284 kc284 added updated Changes completed, please review and removed needs updating A reviewer has requested changes labels Sep 5, 2023
danilo-delbusso
danilo-delbusso suggested changes Sep 6, 2023
View reviewed changes
@danilo-delbusso danilo-delbusso added needs updating A reviewer has requested changes and removed updated Changes completed, please review labels Sep 6, 2023
kc284 added 3 commits September 6, 2023 10:54
@kc284
Added further logging and made the verbose output of cmdlets optional.
c42afc8 
Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Updated README.
0c2d110 
Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Improved script readability.
d79ce94 
Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284 kc284 added updated Changes completed, please review and removed needs updating A reviewer has requested changes labels Sep 6, 2023
CitrixChris
CitrixChris suggested changes Sep 6, 2023
View reviewed changes
@CitrixChris CitrixChris added needs answer PR contains question that needs to be answered 1 approval PR has been approved by one reviewer and removed needs answer PR contains question that needs to be answered labels Sep 6, 2023
@danilo-delbusso danilo-delbusso added 2 approvals PR has been approved by two reviewers and removed 1 approval PR has been approved by one reviewer updated Changes completed, please review labels Sep 6, 2023
@kc284 kc284 merged commit dd98fe6 into xenserver:master Sep 6, 2023
@kc284 kc284 deleted the scripts branch September 6, 2023 14:48
@kc284 kc284 mentioned this pull request Sep 7, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danilo-delbusso danilo-delbusso danilo-delbusso approved these changes

@CitrixChris CitrixChris CitrixChris approved these changes

Assignees

@kc284 kc284

Labels
2 approvals PR has been approved by two reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kc284 @danilo-delbusso @CitrixChris