Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Windows aarch64 (arm64), armv7 support #439

Closed
wants to merge 11 commits into from
Closed

Conversation

xerial
Copy link
Owner

@xerial xerial commented May 23, 2023

Native lib build is failing because of some issues in cmake 3.24.x.
https://gitlab.kitware.com/cmake/cmake/-/issues/24180

-- Check size of unsigned short
CMake Error at /usr/share/cmake-3.24/Modules/CheckTypeSize.cmake:146 (try_compile):
  Cannot copy output executable

    ''

  to destination specified by COPY_FILE:

    '/work/target/snappy-1.1.10-Windows-aarch64/CMakeFiles/CheckTypeSize/CMAKE_SIZEOF_UNSIGNED_SHORT.bin'

  Unable to find the executable at any of:

    /work/target/snappy-1.1.10-Windows-aarch64/CMakeFiles/CMakeTmp/cmTC_accdd
    /work/target/snappy-1.1.10-Windows-aarch64/CMakeFiles/CMakeTmp/Debug/cmTC_accdd
    /work/target/snappy-1.1.10-Windows-aarch64/CMakeFiles/CMakeTmp/Development/cmTC_accdd

Call Stack (most recent call first):
  /usr/share/cmake-3.24/Modules/CheckTypeSize.cmake:277 (__check_type_size_impl)
  /usr/share/cmake-3.24/Modules/TestBigEndian.cmake:55 (CHECK_TYPE_SIZE)
  /usr/share/cmake-3.24/Modules/TestBigEndian.cmake:37 (__TEST_BIG_ENDIAN_LEGACY_IMPL)
  CMakeLists.txt:55 (test_big_endian)

Using cmake 3.26.4 still didn't solve this issue:

-- Check size of unsigned short
CMake Error at /opt/cmake-3.26.4-linux-x86_64/share/cmake-3.26/Modules/CheckTypeSize.cmake:148 (try_compile):
  Cannot copy output executable

    ''

  to destination specified by COPY_FILE:

    '/work/target/snappy-1.1.10-Windows-aarch64/CMakeFiles/CheckTypeSize/CMAKE_SIZEOF_UNSIGNED_SHORT.bin'

  because:

    No such file or directory (input)

@xerial xerial changed the title Feature: Windows arm64, armv7 support Feature: Windows aarch64 (arm64), armv7 support May 23, 2023
@xerial xerial marked this pull request as draft May 23, 2023 19:18
@imsudiproy
Copy link
Contributor

I'll have a look, if I can get a solution

@xerial
Copy link
Owner Author

xerial commented Jul 13, 2023

Probably we should merge the PR without adding windows-arm64 and armv7 targets to the native-all, then add a fix for build failure later

@imsudiproy
Copy link
Contributor

Hi @xerial , I am raising PR for Windows arm64 support.

@xerial
Copy link
Owner Author

xerial commented Sep 26, 2023

Closing in favor of #511

@xerial xerial closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants