-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wauw #26
Open
RobusB100
wants to merge
2,187
commits into
xeroc:master
Choose a base branch
from
Codaone:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wauw #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holy ... quite cool to see that much movement in dexbot. Not sure it makes any sense to merge this upstream as stakemachine is currently unmaintained (no time) |
This fixes fresh install when sqlite database is created from scratch. Instaead of creating with `create_all()` we're dedicating this job to alembic.
Without this migrations files are not accessible in bundled versions.
We're now creating table structure from migrations, this test needs to be adjusted.
This reverts commit 1386d02.
Use pkg_resources to access migrations files. When dexbot is packaged into egg file (normal `setup.py install` result), we cannot just access files inside egg (zip archive), so we're using native setuptools API to extract the files (resource_filename()). In case files are not in egg, pkg_resources will use normal file access. https://setuptools.readthedocs.io/en/latest/pkg_resources.html#basic-resource-access https://setuptools.readthedocs.io/en/latest/setuptools.html#accessing-data-files-at-runtime http://peak.telecommunity.com/DevCenter/PythonEggs#accessing-package-resources
If we're failing to connect to the local node, give up quickly to avoid build stuck.
This needed to run some tests from travis-ci.
Escaping caused travis error
If custom expiration is set and it's too small, it makes a bad condition for worker with cp_from_last_trade active. So just make sure we have default expiration when cp_from_last_trade is used.
* if worker newly created, use market center price * if worker is not new, always try to find own last trade even on startup Closes: #672
Don't limit to 1 op, get all ops and iterate to find first match. This is a preparation to run multiple workers on same account.
Also remove direct graphenelib dependency, we don't need it.
Required version is conflicting with python-graphenelib dependency. Reopen #594
Travis cannot build 5.14.x due to old pip version, the error: AttributeError: module 'sipbuild.api' has no attribute 'prepare_metadata_for_build_wheel' See https://www.riverbankcomputing.com/pipermail/pyqt/2020-January/042430.html
Old hook name Crypto was in conflict with built-in pyinstaller hook, so rename local hook.
Case happens when base or quote balance is not enough to place minimum allowed order when placing lowest buy or highest sell order. Closes: #765
sudo is deprecated and simply has no effect anymore. skip_cleanup is deprecated and replaced with cleanup, which is false by default.
Reverted back some settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insane