Repository navigation
test: 补齐修复后的回归接线与部署说明 - #1129
Merged
Merged
Conversation
部门 HTTP 回归进入完整拓扑 CI,补充文件工具未暴露 delete 的真实注册断言。 修正 OCR 包内模型及锁文件说明,补全 PostgreSQL shm 配额生效步骤和模型别名浏览器证据。 验证:工程契约及66项单测通过;后端3436 passed/1 skipped,配置真实模型目录后OCR三项通过; 前端879项单测、ESLint、tsc、Vite构建、VitePress构建、Ruff、uv lock --check均通过。 独占PostgreSQL与真实HTTP执行三个既有部门用例通过,移除删除用户过滤的负控失败原因正确; 工具注册恢复delete暴露时新断言失败;真实浏览器别名、主题、宽度和实际503后的回退通过。 完整Compose新增步骤待CI,真实登录后的模型目录链路未运行。共享API测试命令被自动审批拒绝,采用隔离验证替代。 已由不继承开发上下文的全新Reviewer审查需求、完整diff、证据与规范并批准。
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
修复已合并 PR 的测试接线和说明缺口:部门 HTTP 回归进入 CI,补充文件工具不暴露 delete 的断言,完善 PostgreSQL 配额生效步骤,纠正 OCR 说明并记录模型别名浏览器证据。
工程主张与 Owner
验证情况
部门 HTTP 计数
PYTHONPATH=backend backend/.venv/bin/python /tmp/yuxi-fix-pr-review/verify_department_http.py,使用仓库isolated_audit_store、serve_http与test_department_router.py三个既有函数;新增完整拓扑 CI 步骤直接运行该测试文件。文件工具暴露
uv run --project backend --no-sync --group test pytest backend/test/unit/sandbox/test_user_sandbox_backend.py -q,35 项通过,断言真实工具名称。回归、文档与浏览器
OCR 补跑由独立 Python 进程将
RAPIDOCR_MODEL_DIR设置为当前 Python 的rapidocr/models包内目录,再运行pytest.main(['backend/test/unit/knowledge/test_rapid_ocr_models.py', '-q']),3 passed。浏览器使用独立 Playwright 会话和临时合成页面,通过playwright-cli -s=yuxi-fix-review run-code --filename=/tmp/yuxi-fix-pr-review/browser-alias.js执行;页面及测试 PostgreSQL 已清理,截图仅保留本地证据,不作为业务链路通过证明。简化 / 删除验收
不涉及。
独立语义 Review
全新上下文 Reviewer 审查需求、完整 diff、规范、实际日志、HTTP 验证与浏览器证据。浏览器错误场景提前通过的问题已修正并重跑,最终批准,无剩余阻塞项。
未验证范围与风险
完整 Compose 新增部门步骤及全部远程检查已通过(Runtime System Tests);真实登录后的后端模型目录链路未运行。共享 API 测试命令被自动审批拒绝,采用独立环境验证。pnpm 自动安装与共享依赖链接不兼容,前端使用脚本对应工具直接执行。
事故反馈
未达到高影响逃逸事故门槛;属于测试接线与说明补修。
界面变更
不改变界面实现;补充 #1116 的浏览器验证证据。
关联事项
补充 #1115、#1116、#1117、#1123、#1124、#1127 的审查交付。
补充说明
无数据迁移或依赖变更,未重建现有业务服务。