change external step binding assembly configuration to use the assemb…

…ly name instead of the file
xerxesb · Apr 29, 2010 · 88e2635 · 88e2635
1 parent 5917ed0
commit 88e2635
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/Runtime/Configuration/ConfigurationSectionHandler.cs b/Runtime/Configuration/ConfigurationSectionHandler.cs
@@ -268,17 +268,17 @@ protected override ConfigurationElement CreateNewElement()
 
         protected override object GetElementKey(ConfigurationElement element)
         {
-            return ((StepAssemblyConfigElement)element).File;
+            return ((StepAssemblyConfigElement)element).Assembly;
         }
     }
 
     public class StepAssemblyConfigElement : ConfigurationElement
     {
-        [ConfigurationProperty("file", DefaultValue = null, IsRequired = false)]
-        public string File
+        [ConfigurationProperty("assembly", DefaultValue = null, IsRequired = false)]
+        public string Assembly
         {
-            get { return (string)this["file"]; }
-            set { this["file"] = value; }
+            get { return (string)this["assembly"]; }
+            set { this["assembly"] = value; }
         }
     }
 }
diff --git a/Runtime/Configuration/RuntimeConfiguration.cs b/Runtime/Configuration/RuntimeConfiguration.cs
@@ -118,9 +118,10 @@ public static RuntimeConfiguration LoadFromConfigFile(ConfigurationSectionHandle
 
             foreach (var element in configSection.StepAssemblies)
             {
-                string stepAssemblyFileName = ((StepAssemblyConfigElement)element).File;
-                string fullPath = Path.GetFullPath(stepAssemblyFileName);
-                Assembly stepAssembly = Assembly.LoadFile(fullPath);
+//                string stepAssemblyFileName = ((StepAssemblyConfigElement)element).File;
+//                string fullPath = Path.GetFullPath(stepAssemblyFileName);
+//                Assembly stepAssembly = Assembly.LoadFile(fullPath);
+                Assembly stepAssembly = Assembly.Load(((StepAssemblyConfigElement)element).Assembly);
                 config._additionalStepAssemblies.Add(stepAssembly);
             }
 

diff --git a/Tests/FeatureTests/App.config b/Tests/FeatureTests/App.config
@@ -22,8 +22,8 @@
             />
 
     <stepAssemblies>
-      <stepAssembly file="..\..\ExternalSteps\ExternalStepsVB\bin\debug\ExternalStepsVB.dll" />
-      <stepAssembly file="..\..\ExternalSteps\ExternalStepsCS\bin\debug\ExternalStepsCS.dll" />
+      <stepAssembly assembly="ExternalStepsVB" />
+      <stepAssembly assembly="ExternalStepsCS" />
     </stepAssemblies>
 
   </specFlow>

diff --git a/Tests/FeatureTests/FeatureTests.csproj b/Tests/FeatureTests/FeatureTests.csproj
@@ -92,6 +92,14 @@
       <Name>TechTalk.SpecFlow</Name>
       <Private>True</Private>
     </ProjectReference>
+    <ProjectReference Include="ExternalSteps\ExternalStepsCS\ExternalStepsCS.csproj">
+      <Project>{3836A6FC-4ECC-413A-AC8F-83A0A773EC9E}</Project>
+      <Name>ExternalStepsCS</Name>
+    </ProjectReference>
+    <ProjectReference Include="ExternalSteps\ExternalStepsVB\ExternalStepsVB.vbproj">
+      <Project>{D3F6B835-B228-4DCF-B533-B6ED469A33B3}</Project>
+      <Name>ExternalStepsVB</Name>
+    </ProjectReference>
   </ItemGroup>
   <ItemGroup>
     <None Include="App.config" />