Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile, Compiler-Warnungen, PlatformIO-Unterstützung #55

Open
wants to merge 65 commits into
base: DEV
Choose a base branch
from

Conversation

AlexanderWillner
Copy link

Diese Pull Request beinhaltet:

  • Ein Makefile hinzugefügt
  • Compiler-Warnungen entfernt
  • PlatformIO-Unterstützung hinzugefügt
  • Ein Fehler bei leerem EEPROM gefixt

junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 3, 2020
inspired by
xfjx#55
xfjx#47

Signed-off-by: Tillmann Heidsieck <[email protected]>
@DerTomm
Copy link

DerTomm commented Jan 4, 2020

A short note: While I really like to see steps towards PIO compatibility I still recommend removing platformio.ini from the repository (as written in PR #53).

The reason for this is that developers might use different environments configured in this file. For example I do not use an Arduino Nano but a barebone Atmega MCU which results in a different ini.

If the file is part of the repo everyone with a differing platformio.ini will have to manually discard their changes before creating a pull request.

@Dakkaron
Copy link

Dakkaron commented Jan 4, 2020

Would it be useful to have a defailt_platformio.ini that contains example settings? Then platformio.ini could be added to .gitignore

@DerTomm
Copy link

DerTomm commented Jan 4, 2020

That's a good idea. What about platformio.ini.example?

@AlexanderWillner
Copy link
Author

I suggest platformio/platformio-core#1590

junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
xfjx#55

Signed-off-by: Tillmann Heidsieck <[email protected]>
junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
xfjx#55

Signed-off-by: Tillmann Heidsieck <[email protected]>
junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
inspired by
xfjx#55
xfjx#47

Signed-off-by: Tillmann Heidsieck <[email protected]>
junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
junkdna added a commit to junkdna/TonUINO that referenced this pull request Jan 4, 2020
xfjx#55

Signed-off-by: Tillmann Heidsieck <[email protected]>
StephenKing added a commit to StephenKing/TonUINO that referenced this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants