Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend handling for move line #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nangtrongvuon
Copy link
Member

@nangtrongvuon nangtrongvuon commented Sep 30, 2018

This adds frontend support for moving lines.

The default hotkeys are Alt + Up/Down for move lines up/down respectively.

Depends on xi-core's #849.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge this whenever the core PR goes in. 😎

@cmyr cmyr added the hold label Oct 22, 2018
@codecov-io
Copy link

Codecov Report

Merging #278 into master will decrease coverage by 1.9%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   45.87%   43.96%   -1.91%     
==========================================
  Files          30       30              
  Lines        3863     3867       +4     
==========================================
- Hits         1772     1700      -72     
- Misses       2091     2167      +76
Impacted Files Coverage Δ
Sources/XiEditor/EditViewController.swift 27.2% <0%> (-10.83%) ⬇️
Sources/XiEditor/AppDelegate.swift 35.29% <0%> (-4.42%) ⬇️
Sources/XiEditor/XiTextPlane/Atlas.swift 76.78% <0%> (-1.79%) ⬇️
Sources/XiEditor/EditView.swift 54.44% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e23d9...cedf8c6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants