refine: propose adjustments to 1 rule(s)#417
Open
claude[bot] wants to merge 1 commit into
Open
Conversation
Narrow R19 (`user-invocable: false`) to exclude standalone commands. The scorer fired on commands whose body is a single unconditional message, treating them as shared partials; 3/4 validated hits were self-false-positives. Added an explicit "Does not apply to" exception. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
🔍 Preview deployPreview URL: https://nlpm.com/_pr/417/ Built from It may take 30–60s for the GitHub Pages CDN to serve the new content. The preview is removed automatically when the PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R19 — noisy
Current metrics: hits=4, merged/contributed=0/0, self-FP=3, maintainer-rejected=0, downstream-suppressions=0
Evidence:
Proposed change: Added a "Does not apply to" paragraph after the R19 principle clarifying that standalone commands — including commands whose body is a single unconditional message — are not shared partials and do not require
user-invocable: false. The rule's scope is restricted to fragments designed to be imported by other commands. This narrows the checker trigger so it cannot misidentify a simple, self-contained command as a partial lacking the flag. 75% of R19's validated hits (3/4) were self-false-positives attributable to this pattern.Proposals not found in
skills/nlpm/rules/SKILL.mdThe following rule IDs from the input do not appear in
skills/nlpm/rules/SKILL.md(they likely live inskills/nlpm/security/SKILL.mdor another skill file, which is out of scope for this workflow). No edits were made; a separate refinement run scoped to the relevant file is needed.scripts/sync-rule-bookkeeping.jsCOUNT_FILESextension) rather than being wrong per se.curl|shinside echo/printf strings, test fixtures, and inert heredoc/string literals printed to stdout vs. executed code.Proposals without usable evidence
threshold_adjustmenttype with "(no reason given)"; no maintainer quotes; no rule-gap signals. Skipped per the "no usable evidence" policy.