Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add an option to enable log through the preference #2097

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

xiaoyifang
Copy link
Owner

@xiaoyifang xiaoyifang commented Jan 22, 2025

Original:
enable log ,will require add the parameter to the goldendict.ext as paramater ,such as --log-to-file

Current:
image

@xiaoyifang xiaoyifang marked this pull request as draft January 22, 2025 13:16
@xiaoyifang
Copy link
Owner Author

need a way to update the option when preference changed.

@xiaoyifang xiaoyifang marked this pull request as ready for review January 23, 2025 03:03
src/main.cc Outdated Show resolved Hide resolved
src/main.cc Outdated Show resolved Hide resolved
xiaoyifang and others added 2 commits January 23, 2025 13:19
Co-authored-by: shenleban tongying <[email protected]>
Co-authored-by: shenleban tongying <[email protected]>
@xiaoyifang xiaoyifang enabled auto-merge (squash) January 23, 2025 10:41
@xiaoyifang xiaoyifang merged commit bd450d7 into staged Jan 23, 2025
9 checks passed
@xiaoyifang xiaoyifang deleted the feat/log-preference branch January 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants