forked from dataarts/dat.guiVR
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gamma correct colorpicker image panel #20
Open
sjpt
wants to merge
26
commits into
xinaesthete:master
Choose a base branch
from
sjpt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,255
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… animate from vrviewer
compensate antialias for scale (not quite right, but much better)
… dead (vScale etc) code, next revision remove it completely
…ut in previous version)
built to match Organic changes, three revision 151 SubdivisionModifier used more consistently
Sounds like an improvement. Remind me to look more properly if I don't get around to merging soon. Also take a look at oklab - seems like quite a useful/interesting color-space... |
folder.js uses simpler z position code, which an prevent folder lockout when too many folders undocked larger MAX_FOLDER_ITEMS_IN_COLUMN = 40
Should be ok, bad gamma of that was annoying I agree. I might want to check a few bits with other changes to folders etc. |
# Conflicts: # build/datguivr.js # build/datguivr.map # build/datguivr.min.js # modules/datguivr/colorpicker.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.