Make JitterBufferPacket user_data a pointer sized field #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it can contain a pointer if desired.
|
@eliotmiranda good catch, I'm wondering if it would make more sense for this to simply be a |
|
Happy either way. But uintptr_t is likely to have less impact on existing clients, so maybe feature-detect C99 and fall back on void * in 64-bits. Messy :-). One could of course define uintptr_t in speex_jitter.h if in 64-bits and not C99. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make JitterBufferPacket.user_data a pointer sized field so that in 64 bits it can contain a pointer if required.