Fix phone regex for international formats #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for international phone numbers with country codes - Maintains backward compatibility with US phone formats - Fixes parsing confidence issues for non-US numbers Fixes xitanggg#146
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current regex
/\(?\d{3}\)?[\s-]?\d{3}[\s-]?\d{4}/is too restrictive for international phone numbers. Numbers with country codes like+91 98765 43210are detected with confidence 0 instead of being properly parsed.Solution
+91,+1,+44, etc.)Testing
Verified with resume parser at localhost:3000/resume-parser:
+91 98765 43210(Indian format) - now parses correctly+1 555 123 4567(US with country code) - now parses correctly(123) 456-7890(existing US format) - still works123-456-7890(existing US format) - still worksBefore/After
Fixes #146