Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-page layout #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tony-ist
Copy link

@tony-ist tony-ist commented Sep 7, 2023

This is an attempt to fix multi-page resumes.

TL;DR: Do not split companies and sections other than work experience when moving them to a new page.

My idea behind this is that work experience is usually the longest section in the resume, so we only move its subsections (companies) to a new page when it does not fit. Other sections are relatively small so we can move the whole section to a new page when it does not fit.

Screenshots for reference:

  1. When work experience does not fit in 1 page:
Screenshot 2023-09-07 at 13 49 37
  1. When other sections do not fit in 1 page:
Screenshot 2023-09-07 at 13 49 51
  1. Possible problem when the work experience heading gets split on the second page. It can only occur when people move work experience to be not the first section. I do not think this is critical:
Screenshot 2023-09-07 at 13 48 58
  1. Another problem is that we do not split anything into a new page on live preview (in production without the debug flag set). The best solution in my opinion would be to introduce a multi-page live preview. But that is out of the scope of this task. One possible change would be to cut out of the live preview all the content that should be on the second page in the resulting PDF. I am not sure about it though.

Let me know what you think about this, I am open to suggestions.

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 11:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant