Updated install.sh

[povzayd]

openjdk-23-jre is removed from the official repo of kali so alot of people are getting error while installing it. Just remove openjdk-23-jre from the 3rd line in install.sh.

[make-ki]

yeah I faced that too, also have you tried running it on non debian-based distros ?

[povzayd]

yeah I faced that too, also have you tried running it on non debian-based distros ?

Nahhhh! never thought about that. I think you just have to change the package manager in the install.sh file & maybe some more minor changes to get that working.

[Pratikchandrathakur]

Code Review for Commit 42a7b0eb0e6cb882e1596f78f553ab419f5fa1f5

Summary

This commit updates install.sh, specifically the dependencies installation line, by removing openjdk-23-jre from the list of packages to be installed. The new line now installs only openjdk-21-jre and openjdk-22-jre (in addition to git and axel).

Review

Positive Aspects:

• Simplifies Dependency Management: Removing openjdk-23-jre likely reduces potential compatibility issues, installation time, and disk usage.
• Clarity: The change is clear and isolated, making it easy to audit and understand.
• Consistency: If the project does not require Java 23, this removal is appropriate and avoids unnecessary installation.

Suggestions & Questions:

1. Reasoning:
   • It would be helpful to include a note in the commit or PR description about why openjdk-23-jre was removed. Was it causing issues, or is it simply not required?
2. Compatibility:
   • Are all project components confirmed to work with Java 21/22 only? If any part requires Java 23, this change could introduce runtime issues.
3. Documentation:
   • If the README or other documentation mentions Java 23, please update those as well for consistency.
4. Testing:
   • After this change, please verify the installation and core functionality on a clean machine to confirm there are no missing dependencies.

Minor:

• Consider alphabetizing or grouping dependencies logically if the list grows in the future.
• If some users might still need openjdk-23-jre, you could mention how to install it manually in the docs.

---

Overall:
This is a straightforward and reasonable update, assuming Java 23 is not needed. Please clarify the motivation, and ensure related documentation and tests are updated accordingly. Nice work!