Skip to content

Commit

Permalink
Use JVM 17 + JavaFX 20 (#5)
Browse files Browse the repository at this point in the history
  • Loading branch information
charneykaye committed Aug 17, 2023
1 parent c0d103a commit 9e8030d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/main_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,28 +18,28 @@ jobs:
- uses: burrunan/gradle-cache-action@v1
name: Cache Gradle
with:
job-id: jdk18
job-id: jdk17

- name: Install and cache system packages
uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: ffmpeg gpac
version: 1.0

- name: Setup JDK 18
- name: Setup JDK 17
uses: actions/setup-java@v1
with:
java-version: 18
java-version: 17
java-package: jdk

- uses: actions/cache@v2
with:
path: |
~/.gradle/caches
~/.gradle/wrapper
key: ${{ runner.os }}-gradle8-java18-${{ hashFiles('**/*.gradle*') }}
key: ${{ runner.os }}-gradle8-java17-${{ hashFiles('**/*.gradle*') }}
restore-keys: |
${{ runner.os }}-gradle8-java18-
${{ runner.os }}-gradle8-java17-
- name: Build & Run Tests
run: "./gradlew --info --no-daemon build test"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ jobs:
- uses: burrunan/gradle-cache-action@v1
name: Cache Gradle
with:
job-id: jdk18
job-id: jdk17

- name: Install and cache system packages
uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: ffmpeg gpac
version: 1.0

- name: Setup JDK 18
- name: Setup JDK 17
uses: actions/setup-java@v1
with:
java-version: 18
java-version: 17
java-package: jdk

- name: Build & Run Tests
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tag_dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macOS-latest, windows-latest ]
java: [ '18' ]
java: [ '17' ]
fail-fast: false
steps:

Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macOS-latest, windows-latest ]
java: [ '18' ]
java: [ '17' ]
fail-fast: false
steps:

Expand Down
2 changes: 1 addition & 1 deletion .java-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.0
17.0
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {
}

ext {
javaFxVersion = '18.0.2'
javaFxVersion = '20.0.2'
junitVersion = '5.9.2'
logbackVersion = '1.4.11'
springBootVersion = '3.1.2'
Expand All @@ -21,8 +21,8 @@ ext {

group = 'io.xj'

sourceCompatibility = JavaVersion.VERSION_18
targetCompatibility = JavaVersion.VERSION_18
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17

mainClassName = 'io.xj.gui.WorkstationGuiApplication'

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/views/main-window.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<?import javafx.scene.layout.Pane?>
<?import javafx.scene.layout.VBox?>
<?import javafx.scene.text.Font?>
<BorderPane xmlns="http://javafx.com/javafx/18.0.2" xmlns:fx="http://javafx.com/fxml/1"
<BorderPane xmlns="http://javafx.com/javafx/20.0.2" xmlns:fx="http://javafx.com/fxml/1"
fx:controller="io.xj.gui.controllers.MainWindowController">
<top>
<VBox prefHeight="386.0" prefWidth="640.0" BorderPane.alignment="CENTER">
Expand Down

0 comments on commit 9e8030d

Please sign in to comment.