Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extsources to vulkan-validation-layers #3153

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

ImperatorS79
Copy link
Contributor

No description provided.

@ImperatorS79
Copy link
Contributor Author

The git repository of this packagessay that only the layer library and the layer manifest are installed by the package (https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/BUILD.md#cmake-installed-files). Why does the xmake package check for header files then ?

@SirLynix
Copy link
Member

The git repository of this packagessay that only the layer library and the layer manifest are installed by the package (https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/BUILD.md#cmake-installed-files). Why does the xmake package check for header files then ?

where does this package check for includes?

@ImperatorS79
Copy link
Contributor Author

ImperatorS79 commented Jan 29, 2024

As far as I understand, there is a on_test function with:

assert(package:has_cxxfuncs("getLayerOption", {includes = "layers/vk_layer_config.h"}))

Maybe I misunderstood that line ? anyway I don't know why the build is failing on so many platform.

@ImperatorS79
Copy link
Contributor Author

ImperatorS79 commented Feb 29, 2024

There is a problemon Android. The url looks like this:

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/$(version1)/android-binaries-$(version2).tar.gz

version1 should be "sdk-versionNumber" or "vulkan-sdk-versionNumber", but version2 should be only "versionNumber".

How can I do that with add_url ?

For example:

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/vulkan-sdk-1.3.275.0/android-binaries-1.3.275.0.tar.gz

But

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/sdk-1.3.261.1/android-binaries-sdk-1.3.261.1-android.tar.gz

@waruqi
Copy link
Member

waruqi commented Feb 29, 2024

There is a problemon Android. The url looks like this:

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/$(version1)/android-binaries-$(version2).tar.gz

version1 should be "sdk-versionNumber" or "vulkan-sdk-versionNumber", but version2 should be only "versionNumber".

How can I do that with add_url ?

For example:

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/vulkan-sdk-1.3.275.0/android-binaries-1.3.275.0.tar.gz

But

https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/download/sdk-1.3.261.1/android-binaries-sdk-1.3.261.1-android.tar.gz

$(version1)/android-binaries-$(version2)

-> $(version) and return version1 .. "android-binaries-" .. version2

@ImperatorS79
Copy link
Contributor Author

It seems to be working now

@waruqi waruqi merged commit b9085ea into xmake-io:dev Mar 3, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants