Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NDK r26 #3159

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add NDK r26 #3159

merged 5 commits into from
Jan 24, 2024

Conversation

zebede22
Copy link
Contributor

Add latest NDK LTS:
https://github.com/android/ndk/wiki

Package for darwin systems are not provided as zip anymore but as .dmg files.
I don't know how to handle them, so skipping for now

@SirLynix SirLynix changed the title NDK LTS Add NDK r26 Jan 24, 2024
@SirLynix
Copy link
Member

@waruqi how should xmake deal with .dmg files?

@zebede22
Copy link
Contributor Author

@waruqi how should xmake deal with .dmg files?

There is this one using .dmg but not sure how it works:

add_urls("https://registrationcenter-download.intel.com/akdlm/irc_nas/18341/m_HPCKit_p_$(version)_offline.dmg", {version = function(version)

@SirLynix
Copy link
Member

nevermind, the .zip file exists for macOS too

@waruqi
Copy link
Member

waruqi commented Jan 24, 2024

@waruqi how should xmake deal with .dmg files?

There is this one using .dmg but not sure how it works:

add_urls("https://registrationcenter-download.intel.com/akdlm/irc_nas/18341/m_HPCKit_p_$(version)_offline.dmg", {version = function(version)

here

local result = os.iorunv("hdiutil", {"attach", package:originfile()})

But the code here never seems to get executed to, and I'm not sure it would work.

@waruqi waruqi merged commit 699e93f into xmake-io:dev Jan 24, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants