add GLPK package #3165
add GLPK package #3165
Conversation
| assert(package:check_cxxsnippets({test = [[ | ||
| #include <glpk.h> | ||
| int main() { | ||
| return 0; |
There was a problem hiding this comment.
Please add some api call to link.
packages/g/glpk/xmake.lua
Outdated
|
|
||
| add_versions("5.0", "4a1013eebb50f728fc601bdd833b0b2870333c3b3e5a816eeba921d95bec6f15") | ||
|
|
||
| add_extsources("apt::libglpk-dev") |
There was a problem hiding this comment.
if is_plat("linux") then
add_extsources("apt::libglpk-dev")
end
|
I've added support for building the library for Windows. |
packages/g/glpk/xmake.lua
Outdated
| end | ||
|
|
||
| if is_plat("macosx|x86_64", "linux") then | ||
| add_deps("autoconf", "automake", "libtool", "pkg-config") |
There was a problem hiding this comment.
if ./configure file exists, we need not add these deps. they are only for ./autogen.sh to generate configure.
There was a problem hiding this comment.
OK, I removed these lines
packages/g/glpk/xmake.lua
Outdated
|
|
||
| add_versions("5.0", "4a1013eebb50f728fc601bdd833b0b2870333c3b3e5a816eeba921d95bec6f15") | ||
|
|
||
| add_configs("shared", {description = "Build shared binaries", default = false, type = "boolean"}) |
There was a problem hiding this comment.
? if this library only support static library, we should set readonly = true, otherwise please remove it.
There was a problem hiding this comment.
OK, I also removed this line
packages/g/glpk/xmake.lua
Outdated
| end | ||
|
|
||
| on_install("macosx|x86_64", "linux", function (package) | ||
| import("package.tools.autoconf").install(package) |
There was a problem hiding this comment.
please add static/shared configs
There was a problem hiding this comment.
The configure script provides both --enable-shared and --enable-static and both are set to yes. Should I disable one of these two according to static/shared configs?
There was a problem hiding this comment.
local configs = {}
table.insert(configs, "--enable-shared=" .. (package:config("shared") and "yes" or "no"))
table.insert(configs, "--enable-static=" .. (package:config("shared") and "no" or "yes"))
import("package.tools.autoconf").install(package, configs)
packages/g/glpk/xmake.lua
Outdated
| end) | ||
|
|
||
| on_install("windows", function (package) | ||
| os.cd(is_arch("x64", "x86_64") and "w64" or "w32") |
There was a problem hiding this comment.
I simplified this line, as the Makefiles are the same in both directories (I put a comment in the file)
This PR adds the GLPK package. "The GLPK (GNU Linear Programming Kit) package is intended for solving large-scale linear programming (LP), mixed integer programming (MIP), and other related problems."