Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of libiconv on android@windows #4299

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

zjyhjqs
Copy link
Contributor

@zjyhjqs zjyhjqs commented Jun 9, 2024

No description provided.

@zjyhjqs
Copy link
Contributor Author

zjyhjqs commented Jun 9, 2024

android@windows我本地测试是正常的, CI上不知道出了什么问题

error: @programdir\core\sandbox\modules\os.lua:273: builddir="pwd"; cd libcharset && make all && make install-lib libdir="$builddir/lib" includedir="$builddir/lib"

我的本机没有MSYS环境, 也是通过xrepo安装的. 但这错误信息看着仍然像缺环境


MingW部分的我这次修改应该没影响. 看错误信息就更奇怪了

error: @programdir\core\main.lua:329: @programdir\actions\build\main.lua:148: @programdir\modules\async\runjobs.lua:325: @programdir\modules\private\action\build\object.lua:91: @programdir\modules\core\tools\gcc.lua:901: srclib\safe-read.c: In function 'safe_read':
srclib\safe-read.c:47:13: error: implicit declaration of function 'read' [-Wimplicit-function-declaration]
47 | # define rw read
| ^~~~
srclib\safe-read.c:60:24: note: in expansion of macro 'rw'
60 | ssize_t result = rw (fd, buf, count);
|

基本看出是缺了头, 但在原有的脚本中把它删去了

io.gsub("srclib/safe-read.c", "#include <unistd.h>", "")
io.gsub("srclib/progreloc.c", "#include <unistd.h>", "")

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


android@windows My local test is normal, but I don’t know what went wrong on CI

error: @programdir\core\sandbox\modules\os.lua:273: builddir="pwd"; cd libcharset && make all && make install-lib libdir="$builddir/lib" includedir="$builddir/ lib"

My machine does not have an MSYS environment, and it was installed through xrepo. But the error message still looks like the environment is missing.


My modifications to the MingW part should have no effect. The error message is even more strange.

error: @programdir\core\main.lua:329: @programdir\actions\build\main.lua:148: @programdir\modules\async\runjobs.lua:325: @programdir\modules\private\action\build \object.lua:91: @programdir\modules\core\tools\gcc.lua:901: srclib\safe-read.c: In function 'safe_read':
srclib\safe-read.c:47:13: error: implicit declaration of function 'read' [-Wimplicit-function-declaration]
47 | # define rw read
| ^~~~
srclib\safe-read.c:60:24: note: in expansion of macro 'rw'
60 | ssize_t result = rw (fd, buf, count);
|

Basically it looked like the head was missing, but it was deleted in the original script.

io.gsub("srclib/safe-read.c", "#include <unistd.h>", "")
io.gsub("srclib/progreloc.c", "#include <unistd.h>", "")

@zjyhjqs
Copy link
Contributor Author

zjyhjqs commented Jun 10, 2024

android@windows我本地测试是正常的, CI上不知道出了什么问题

用windows sandbox初始环境启动仍然可以正常过。现在怀疑是否和Win10有关

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


My local test on android@windows is normal, but I don’t know what went wrong on CI.

It can still be started normally using the windows sandbox initial environment. Now I wonder if it has something to do with Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants