Add poco msys and mingw version #4390

TabNahida · 2024-06-18T00:37:10Z

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

waruqi · 2024-06-27T03:00:37Z

packages/p/poco/xmake.lua

@@ -21,7 +21,7 @@ package("poco")
    end
    add_configs("mysql", {description = "Enable mysql support.", default = false, type = "boolean"})
    add_configs("postgresql", {description = "Enable postgresql support.", default = false, type = "boolean"})
-    add_configs("odbc", {description = "Enable odbc support.", default = is_plat("windows"), type = "boolean"})
+    add_configs("odbc", {description = "Enable odbc support.", default = is_plat("windows") or not is_plat("mingw"), type = "boolean"})


why? or not?

Odbc support must on mingw platform

why not is_plat("windows", "mingw")?

is_plat("windows") or not is_plat("mingw")

is_plat("windows") It is a redundant condition, becasee windows always satisfy or not is_plat("mingw")

waruqi · 2024-06-30T12:25:09Z

packages/p/poco/xmake.lua

@@ -21,7 +21,7 @@ package("poco")
    end
    add_configs("mysql", {description = "Enable mysql support.", default = false, type = "boolean"})
    add_configs("postgresql", {description = "Enable postgresql support.", default = false, type = "boolean"})
-    add_configs("odbc", {description = "Enable odbc support.", default = is_plat("windows") or not is_plat("mingw"), type = "boolean"})
+    add_configs("odbc", {description = "Enable odbc support.", default = is_plat("windows") and not is_plat("mingw", "msys"), type = "boolean"})


? windows -> true, other -> always false

the original setting for other platform is false. And MingW and msys platform need this be false to pass the compile.

the original settings: windows-> true, other -> false
the current settings: windows -> true, other -> false

I don't see any difference.

TabNahida · 2024-07-01T08:42:38Z

@waruqi I cannot actually fix the bug of the building. Msys x64 platform on my computer cannot be compiled successfully but it passed on github action.

waruqi · 2024-07-03T03:34:07Z

packages/p/poco/xmake.lua

    end)

-    on_install("windows", "linux", "macosx", function (package)
+    on_install("windows", "linux", "macosx", "mingw@!macosx|x86_64", "msys|x86_64", function (package)


没这种写法

i686和i386架构跑不了

我要禁这个两个架构

那你直接填 mingw|x86_64 不就好了么。

那你直接填 mingw|x86_64 不就好了么。

我之前试过了啊，macosx mingw的x86_64过不了

那你直接填 mingw|x86_64 不就好了么。

我之前试过了啊，macosx mingw的x86_64过不了

那你到底要干啥。。凡事一次性说完整，你刚只说了要禁 i686/i386 没说要禁 x86_64 。。

i686和i386架构跑不了
我要禁这个两个架构

另外，mingw 都禁的差不多了，那还不如不启用 mingw 了，，要么就把过不了的 error 全修了

另外，mingw 都禁的差不多了，那还不如不启用 mingw 了，，要么就把过不了的 error 全修了

本来就是仿照msys的包，它只给了三个架构

这个是msys的包构建策略
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-poco/PKGBUILD

另外，mingw 都禁的差不多了，那还不如不启用 mingw 了，，要么就把过不了的 error 全修了

我查了，应该在mac上是cmake没有识别成mingw而是识别到macos了，然后就是在i686架构下，limits头文件未添加

不是，是它压根没考虑到 mac mingw 的情况，仅支持 windows 上的 mingw

https://github.com/pocoproject/poco/blob/2442c66f84616b05e072fa49e77c15d0d5ab08cc/cmake/PocoMacros.cmake#L43

waruqi · 2024-07-03T08:51:29Z

packages/p/poco/xmake.lua

@@ -44,7 +45,7 @@ package("poco")
        end
    end)

-    on_install("windows", "linux", "macosx", function (package)
+    on_install("windows", "linux", "macosx", "mingw", "msys", function (package)


msys 平台不是 mingw ，是指的 msys2 下 gcc.exe toolchain，你确定这个包支持？

这个库，估计顶多也就支持 mingw@msys ，除非你加 patch 给它强行支持上

msys 平台不是 mingw ，是指的 msys2 下 gcc.exe toolchain，你确定这个包支持？

msys2 的pacman上有

msys 平台不是 mingw ，是指的 msys2 下 gcc.exe toolchain，你确定这个包支持？

msys2 的pacman上有

你还是没明白我说的。。就你上面那个 pacman 图给的包，就是 msys2 上 pacman 提供的 mingw 包。。也就是 mingw@msys ，意思就是 msys2 下的 mingw 编译平台。。

而 msys 平台用的是 msys2 下原始 gcc.exe 工具链，不是 mingw toolchain 。。

而 mingw 平台，包含 mingw@msys2 + mingw@macosx ，也就是 msys2/macos 下的 mingw 工具链。。

msys 平台不是 mingw ，是指的 msys2 下 gcc.exe toolchain，你确定这个包支持？

msys2 的pacman上有

你还是没明白我说的。。就你上面那个 pacman 图给的包，就是 msys2 上 pacman 提供的 mingw 包。。也就是 mingw@msys ，意思就是 msys2 下的 mingw 编译平台。。

而 msys 平台用的是 msys2 下原始 gcc.exe 工具链，不是 mingw toolchain 。。

而 mingw 平台，包含 mingw@msys2 + mingw@macosx ，也就是 msys2/macos 下的 mingw 工具链。。

所以其实这个就只支持mingw@msys平台，而且是只有x86_64架构

对啊，所以 msys 平台加来干嘛。。

对啊，所以 msys 平台加来干嘛。。

那就开一个mingw@msys吧，mac那个我搞不定

waruqi · 2024-07-03T09:06:38Z

packages/p/poco/xmake.lua

            table.insert(configs, "-DENABLE_DATA_" .. lib:upper() .. "=" .. (package:config(lib) and "ON" or "OFF"))
        end
-
+
+        if is_subhost("msys") and is_arch("x86_64") then


还有这。用 package:is_arch ，另外为啥要用 is_subhost ? 不应该判断 mingw platform 么

还有这。用 package:is_arch ，另外为啥要用 is_subhost ? 不应该判断 mingw platform 么

好的我已经改了一次了

waruqi · 2024-07-03T09:07:22Z

packages/p/poco/xmake.lua

            table.insert(configs, "-DENABLE_DATA_" .. lib:upper() .. "=" .. (package:config(lib) and "ON" or "OFF"))
        end
-
+
+        if is_host("mingw") then


没有 mingw 这个 host ，只有平台

waruqi · 2024-07-03T09:07:46Z

packages/p/poco/xmake.lua

-
+
+        if is_host("mingw") then
+            table.insert(configs, "-DPOCO_DATA_NO_SQL_PARSER=ON")


另外，这个应该做成 sql_parser 的 config

waruqi · 2024-07-03T09:08:11Z

packages/p/poco/xmake.lua

            table.insert(configs, "-DENABLE_DATA_" .. lib:upper() .. "=" .. (package:config(lib) and "ON" or "OFF"))
        end
-
+
+        if is_plat("mingw") then


用 package:is_plat

waruqi · 2024-07-03T09:17:21Z

packages/p/poco/xmake.lua

-
+
+        if package:is_plat("mingw") then
+            table.insert(configs, "-DPOCO_DATA_NO_SQL_PARSER=" .. (package:config("sql_parser") and "OFF" or "ON"))


不对啊，应该根据 config 去 enable/disable 。。。平台判断设置 default value，哪有倒过来的。。其他平台这个 config 不等于还是没用上

另外，没有 ENABLE_DATA_SQL_PARSER 么。。上面 mysql 上的都有这些配置

另外，没有 ENABLE_DATA_SQL_PARSER 么。。上面 mysql 上的都有这些配置

好像没有

TabNahida · 2024-07-03T14:28:50Z

@waruqi 如果你觉得现在可以合并就合并吧，我不想再折腾了。虽然现在其实就增加了一个平台但是应该够了，我后面再来看吧

Issues-translate-bot · 2024-07-03T14:29:05Z

Bot detected the issue body's language is not English, translate it automatically.

@waruqi If you think it can be merged now, just merge it. I don’t want to bother anymore. Although it’s actually just one more platform now, it should be enough. I’ll look at it later.

zeroxer · 2024-07-07T07:57:06Z

mark: windows poco install failed.
xrepo install poco
- get error about msys, my toolchain is msvc

-- Detecting C compile features - done
-- Could NOT find BZip2 (missing: BZIP2_LIBRARIES BZIP2_INCLUDE_DIR) 
-- Found ZLIB: D:/Apps/ScoopHome/App/apps/msys2/current/mingw64/lib/libz.dll.a (found version "1.2.13")  
-- Could not find OPTIONAL package Readline
-- Could not find OPTIONAL package Editline
.......

D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(389,32): error C2085: '_exit': not in formal parameter list [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\10. 
       42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(389,49): error C2143: syntax error: missing ';' before 'type' [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\1 
       0.42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(396,16): error C2085: '_Exit': not in formal parameter list [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\10. 
       42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(396,27): error C2143: syntax error: missing ';' before 'type' [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\1 
       0.42\source\build_9524e0ca\pcre2-8-static.vcxproj]

it seems that pcre2 used some include in my msys env which is wrong.

TabNahida · 2024-07-07T11:31:29Z

mark: windows poco install failed.
xrepo install poco
- get error about msys, my toolchain is msvc

-- Detecting C compile features - done
-- Could NOT find BZip2 (missing: BZIP2_LIBRARIES BZIP2_INCLUDE_DIR) 
-- Found ZLIB: D:/Apps/ScoopHome/App/apps/msys2/current/mingw64/lib/libz.dll.a (found version "1.2.13")  
-- Could not find OPTIONAL package Readline
-- Could not find OPTIONAL package Editline
.......

D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(389,32): error C2085: '_exit': not in formal parameter list [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\10. 
       42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(389,49): error C2143: syntax error: missing ';' before 'type' [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\1 
       0.42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(396,16): error C2085: '_Exit': not in formal parameter list [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\10. 
       42\source\build_9524e0ca\pcre2-8-static.vcxproj]
         D:\Apps\ScoopHome\App\apps\msys2\current\mingw64\include\stdlib.h(396,27): error C2143: syntax error: missing ';' before 'type' [C:\Users\Dev\AppData\Local\.xmake\cache\packages\2407\p\pcre2\1 
       0.42\source\build_9524e0ca\pcre2-8-static.vcxproj]

it seems that pcre2 used some include in my msys env which is wrong.

Full log is needed to fix your problem.

TabNahida and others added 2 commits June 18, 2024 08:36

add msys

3910117

Merge branch 'xmake-io:dev' into dev

c6522ca

waruqi reviewed Jun 27, 2024

View reviewed changes

TabNahida and others added 3 commits June 28, 2024 08:09

Merge branch 'xmake-io:dev' into dev

39df464

Update xmake.lua

a174a75

Merge branch 'xmake-io:dev' into dev

3e3d536

waruqi reviewed Jun 30, 2024

View reviewed changes

TabNahida and others added 7 commits July 3, 2024 02:07

Update xmake.lua

61c351d

Merge branch 'dev' of https://github.com/TabNahida/xmake-repo into dev

7f31e0e

Merge branch 'xmake-io:dev' into dev

25efd85

Update xmake.lua

5988e5f

Merge branch 'dev' of https://github.com/TabNahida/xmake-repo into dev

03a36e1

Update xmake.lua

8813337

Update xmake.lua

765d868

waruqi reviewed Jul 3, 2024

View reviewed changes

waruqi and others added 8 commits July 3, 2024 11:35

Update xmake.lua

7e52499

Update xmake.lua

af40ef2

Update xmake.lua

9e648e7

Update xmake.lua

e2df379

Update xmake.lua

f4f76bf

Update xmake.lua

768f8af

Update xmake.lua

d2c57d5

Update xmake.lua

3a88cd0

waruqi reviewed Jul 3, 2024

View reviewed changes

Update xmake.lua

f0cc43c

waruqi reviewed Jul 3, 2024

View reviewed changes

Update xmake.lua

d340216

waruqi reviewed Jul 3, 2024

View reviewed changes

Update xmake.lua

f373cab

waruqi reviewed Jul 3, 2024

View reviewed changes

Update xmake.lua

3fc1724

waruqi added 2 commits July 3, 2024 23:06

Update xmake.lua

e676695

Update xmake.lua

cc3076d

waruqi merged commit a627341 into xmake-io:dev Jul 4, 2024
65 checks passed

TabNahida mentioned this pull request Aug 6, 2024

The Build Failure in Msys pocoproject/poco#4598

Open



		if is_host("mingw") then
		table.insert(configs, "-DPOCO_DATA_NO_SQL_PARSER=ON")



		if package:is_plat("mingw") then
		table.insert(configs, "-DPOCO_DATA_NO_SQL_PARSER=" .. (package:config("sql_parser") and "OFF" or "ON"))

Add poco msys and mingw version #4390

Add poco msys and mingw version #4390

Conversation

TabNahida commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TabNahida commented Jul 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TabNahida Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TabNahida commented Jul 3, 2024

Issues-translate-bot commented Jul 3, 2024

zeroxer commented Jul 7, 2024 • edited Loading

TabNahida commented Jul 7, 2024

TabNahida Jul 3, 2024 •

edited

Loading

zeroxer commented Jul 7, 2024 •

edited

Loading