add macdylibbundler package #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Jul 8, 2024
| add_files("src/*.cpp") | ||
| add_includedirs("src") | ||
|
|
||
| add_headerfiles("src/*.h") |
There was a problem hiding this comment.
就这么几行，就没必要单独一个 port 了。。直接 on_install 里，io.writefile 写下不就好了么。。
There was a problem hiding this comment.
因为参考了11zip的写法，所以就直接添加了一个port。
There was a problem hiding this comment.
之前不太熟悉这种写法，学习了，以后如果行数比较少就直接在on install里处理
|
还有为啥会有这么多不相关的 commit |
And why are there so many irrelevant commits? |
|
不好意思，今天早上出去了，所以没看到你的建议 |
Sorry, I went out this morning, so I didn’t see your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加了macdylibbundler的安装脚本