soci: fix deps #5022
soci: fix deps #5022
Conversation
packages/s/soci/xmake.lua
Outdated
| end | ||
| end | ||
| assert(package:has_cxxtypes("soci::session", {configs = {languages = "c++14"}, includes = "soci/soci.h"})) | ||
| assert(package:has_cxxincludes(includes, {configs = {languages = "c++14"}})) |
There was a problem hiding this comment.
please use check_cxxsnippets.
has_cxxtypes/has_cxxincludes does not check links.
There was a problem hiding this comment.
The current CI failure is because we are using NDK r27 to test against Android packages. To resolve this issue and make the CI happy, you could consider patching the CMakeLists to include a line containing cmake_policy(SET CMP0057 NEW), or you can update the minimum required version of CMake.
Alternatively, we can merge this as it is for now. @waruqi
packages/s/soci/xmake.lua
Outdated
|
|
||
| add_deps("cmake") | ||
| add_deps("cmake <=3.20", {private = true}) |
There was a problem hiding this comment.
Because the CMake dependency is transitively propagated to my project, but it should be only necessary to build this library. Is there a better option?
|
we can add on_check to make ci happy. |
we can add on_check to make ci happy. |
packages/s/soci/xmake.lua
Outdated
|
|
||
| add_deps("cmake") | ||
| add_deps("cmake <=3.20", {private = true}) |
There was a problem hiding this comment.
I mean patch the lower bound version at this link, not in the xmake port file.
There was a problem hiding this comment.
I made the patch, the checksum works on windows but fails on every other platform.
There was a problem hiding this comment.
Probably because the checksum was made on a CRLF file, turn the line endings to LF and check it again
Fixes #5021