Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soci: fix deps #5022

Merged
merged 1 commit into from
Sep 2, 2024
Merged

soci: fix deps #5022

merged 1 commit into from
Sep 2, 2024

Conversation

bkmeneguello
Copy link
Contributor

Fixes #5021

end
end
assert(package:has_cxxtypes("soci::session", {configs = {languages = "c++14"}, includes = "soci/soci.h"}))
assert(package:has_cxxincludes(includes, {configs = {languages = "c++14"}}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use check_cxxsnippets.

has_cxxtypes/has_cxxincludes does not check links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@c8ef c8ef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CI failure is because we are using NDK r27 to test against Android packages. To resolve this issue and make the CI happy, you could consider patching the CMakeLists to include a line containing cmake_policy(SET CMP0057 NEW), or you can update the minimum required version of CMake.

Alternatively, we can merge this as it is for now. @waruqi


add_deps("cmake")
add_deps("cmake <=3.20", {private = true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set private = true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the CMake dependency is transitively propagated to my project, but it should be only necessary to build this library. Is there a better option?

@waruqi
Copy link
Member

waruqi commented Aug 24, 2024

we can add on_check to make ci happy.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


we can add on_check to make ci happy.


add_deps("cmake")
add_deps("cmake <=3.20", {private = true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean patch the lower bound version at this link, not in the xmake port file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the patch, the checksum works on windows but fails on every other platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because the checksum was made on a CRLF file, turn the line endings to LF and check it again

@waruqi waruqi merged commit 1c42eb3 into xmake-io:dev Sep 2, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soci: Can't detect dependencies (sqlite3, mysql, postgresql, and boost)
5 participants