Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vld: fix format error #5165

Merged
merged 3 commits into from
Sep 7, 2024
Merged

vld: fix format error #5165

merged 3 commits into from
Sep 7, 2024

Conversation

heheda123123
Copy link
Contributor

No description provided.

@heheda123123 heheda123123 mentioned this pull request Sep 7, 2024
@heheda123123
Copy link
Contributor Author

@star-hengxing 测试通过了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@star-hengxing test passed

@heheda123123
Copy link
Contributor Author

咦,为啥不用io.replace测试可以,之前我记得就是通不过才patch的

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Hey, why don't you use io.replace to test it? I remember that it failed before patching.

@star-hengxing
Copy link
Contributor

咦,为啥不用io.replace测试可以,之前我记得就是通不过才patch的

看 patch 文件,属于测试部分,而包管理不需要编译测试,所以既然用了 -t:vld 指定只构建库而不是测试,那这部分就可以删了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Hey, why don’t you use io.replace to test it? I remember that it failed before patching.

Looking at the patch file, it belongs to the testing part, and package management does not require compilation and testing, so since -t:vld is used to specify only building the library instead of testing, this part can be deleted

@star-hengxing star-hengxing merged commit 31a2552 into xmake-io:dev Sep 7, 2024
65 checks passed
@heheda123123
Copy link
Contributor Author

咦,为啥不用io.replace测试可以,之前我记得就是通不过才patch的

看 patch 文件,属于测试部分,而包管理不需要编译测试,所以既然用了 -t:vld 指定只构建库而不是测试,那这部分就可以删了

之前也指定了-t vld的

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Hey, why don't you use io.replace to test it? I remember that I couldn't pass it before patching it.

Look at the patch file, it belongs to the testing part, and package management does not require compilation and testing, so since -t:vld is used to specify only building the library instead of testing, this part can be deleted

-t vld was also specified before

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants